fix flake update

.github/workflows/diff-pr.yml

@@ -17,18 +17,10 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.pull_request.head.sha }}
           fetch-depth: 0
 
-      - name: merge base branch
-        run: |
-          git config user.email "ci@localhost"
-          git config user.name "CI"
-          git fetch origin ${{ github.event.pull_request.base.ref }}
-          git merge --no-edit origin/${{ github.event.pull_request.base.ref }}
-
       - name: worktree base for diff
-        run: git worktree add "$RUNNER_TEMP/base" "origin/${{ github.event.pull_request.base.ref }}"
+        run: git worktree add "$RUNNER_TEMP/base" "${{ github.event.pull_request.base.sha }}"
 
       - name: build closures and render diff
         run: |

.github/workflows/flake-update.yml

@@ -5,19 +5,21 @@ on:
     - cron: "17 4 * * *"
   workflow_dispatch:
 
+permissions:
+  contents: write
+  pull-requests: write
+
 jobs:
   update:
     runs-on: nix
     steps:
       - uses: actions/checkout@v4
-        with:
-          persist-credentials: false
 
       - run: nix flake update -L
 
       - name: open/update PR
         env:
-          GH_TOKEN: ${{ secrets.BOT_TOKEN }}
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           API: ${{ github.api_url }}
           REPO: ${{ github.repository }}
         run: |

ci.py

@@ -8,7 +8,6 @@ import re
 import subprocess
 import subprocess_tee
 import sys
-import urllib.error
 import urllib.request
 from collections import Counter
 from pathlib import Path
@@ -27,10 +26,6 @@ def git(*args, check=True):
     return run("git", *args, check=check, capture_output=True)
 
 
-class GiteaError(Exception):
-    pass
-
-
 def gitea(method, path, body=None):
     url = f'{os.environ["API"]}/repos/{os.environ["REPO"]}{path}'
     data = json.dumps(body).encode() if body is not None else None
@@ -42,11 +37,7 @@ def gitea(method, path, body=None):
         with urllib.request.urlopen(req) as resp:
             raw = resp.read()
     except urllib.error.HTTPError as e:
-        try:
+        sys.exit(f"gitea {method} {path}: {e.code} {e.reason}\n{e.read().decode()}")
-            detail = json.loads(e.read()).get("message", e.reason)
-        except (json.JSONDecodeError, UnicodeDecodeError):
-            detail = e.reason
-        raise GiteaError(f"{method} {path}: {e.code} {detail}") from None
     return json.loads(raw) if raw else None
 
 
@@ -475,24 +466,16 @@ def open_pr(args):
 
     host = os.environ["API"].removesuffix("/api/v1")
     auth = base64.b64encode(f'token:{os.environ["GH_TOKEN"]}'.encode()).decode()
-    push = git("-c", f"http.extraHeader=Authorization: Basic {auth}",
+    git("-c", f"http.extraHeader=Authorization: Basic {auth}",
-               "push", "-f", f'{host}/{os.environ["REPO"]}.git', f"HEAD:{args.branch}",
+        "push", "-f", f'{host}/{os.environ["REPO"]}.git', f"HEAD:{args.branch}")
-               check=False)
-    if push.returncode != 0:
-        raise RuntimeError(f"git push failed:\n{push.stderr}")
 
-    pulls = gitea("GET", f"/pulls?state=open&base_branch={args.base}")
+    owner = os.environ["REPO"].split("/")[0]
-    existing = next((pr for pr in pulls if pr["head"]["ref"] == args.branch), None)
+    if gitea("GET", f"/pulls?state=open&head={owner}:{args.branch}"):
-    if existing:
-        print(f"PR #{existing['number']} already open, pushed update")
         return
     labels = [label_id(args.label)] if args.label else []
-    pr = gitea("POST", "/pulls",
+    gitea("POST", "/pulls",
           {"title": args.title, "head": args.branch, "base": args.base,
            "body": Path(args.body_file).read_text(), "labels": labels})
-    if not pr or "number" not in pr:
-        raise GiteaError(f"POST /pulls: unexpected response: {json.dumps(pr)}")
-    print(f"opened PR #{pr['number']}")
 
 
 def main():

configuration.nix

@@ -5,7 +5,6 @@
   hostInfo,
   customPkgs,
   flakeRev,
-  deployLabel,
   ...
 }:
 let
@@ -63,7 +62,14 @@ in
 
   time.timeZone = "UTC";
   system.stateVersion = "26.05";
-  system.nixos.label = if deployLabel != null then deployLabel else flakeRev;
+  system.nixos.label =
+    let
+      labelFile = ./.nixos-label;
+    in
+    if builtins.pathExists labelFile then
+      lib.removeSuffix "\n" (builtins.readFile labelFile)
+    else
+      flakeRev;
 
   nix = {
     settings = {

containers/server-n0/git.nix

@@ -176,8 +176,9 @@ in
               PermitEmptyPasswords = "yes";
             };
           };
+          security.pam.services.sshd.allowNullPassword = true;
           users.users.root.initialHashedPassword = "";
-          services.journald.extraConfig = "ForwardToConsole=yes";
+          services.journald.settings.Journal.ForwardToConsole = "yes";
 
           virtualisation.containerd.enable = true;
           virtualisation.containerd.settings.plugins."io.containerd.snapshotter.v1.overlayfs".mount_options =

dsl.nix

@@ -1269,7 +1269,7 @@ rec {
         # containers don't forward journal to console by default
         containers = lib.genAttrs nspawnNames (_: {
           timeoutStartSec = "10min";
-          config.services.journald.extraConfig = "ForwardToConsole=yes";
+          config.services.journald.settings.Journal.ForwardToConsole = "yes";
         });
 
         # a test VM has neither the memory to hand out nor the cores to divide.

flake.lock

@@ -1,17 +1,5 @@
 {
   "nodes": {
-    "deploy-label": {
-      "flake": false,
-      "locked": {
-        "path": "./misc/deploy-label",
-        "type": "path"
-      },
-      "original": {
-        "path": "./misc/deploy-label",
-        "type": "path"
-      },
-      "parent": []
-    },
     "flake-utils": {
       "inputs": {
         "systems": "systems"
@@ -38,11 +26,11 @@
         "spectrum": "spectrum"
       },
       "locked": {
-        "lastModified": 1786300091,
+        "lastModified": 1789506833,
-        "narHash": "sha256-4UFJOVGpaYtHW5yasSv80MaJxTBYdk2zyf3jhKtt0wA=",
+        "narHash": "sha256-4L8SOCF84de1irB72Ka9VHcu9wrAJ9Amuey4lU9oh4Y=",
         "owner": "microvm-nix",
         "repo": "microvm.nix",
-        "rev": "71beea0076cd46dafcee97a5a2e7d00cbba5bd2f",
+        "rev": "187b0a390ee054028106a674e7b01b1cb940cbba",
         "type": "github"
       },
       "original": {
@@ -75,11 +63,11 @@
     },
     "nixpkgs": {
       "locked": {
-        "lastModified": 1786384358,
+        "lastModified": 1789546076,
-        "narHash": "sha256-RzPPiWeUtuvymnpuEWsdtzli5w4kjZs49FqEs3/1u+I=",
+        "narHash": "sha256-zVxLZiSnmaaPLwnhj7pwmqe3axBg/C6nG5JZsJMh2g4=",
         "owner": "NixOS",
         "repo": "nixpkgs",
-        "rev": "2fcb964de67fcf60b43471c55d5d99e61a9ccb5a",
+        "rev": "b1b875982b17dabde9b4a37f3e229e74913e6db3",
         "type": "github"
       },
       "original": {
@@ -91,7 +79,6 @@
     },
     "root": {
       "inputs": {
-        "deploy-label": "deploy-label",
         "microvm": "microvm",
         "mtce": "mtce",
         "nixpkgs": "nixpkgs"
@@ -100,11 +87,11 @@
     "spectrum": {
       "flake": false,
       "locked": {
-        "lastModified": 1785761586,
+        "lastModified": 1786032750,
-        "narHash": "sha256-MWOMVqJJERwjQGgRIv8d6rlEBqbLM3VZWxHkNKIIZNw=",
+        "narHash": "sha256-+Ba/kIn5BjvV7PN8bWOo7RoqgTY/Yv2M7qeMf3wS2Ag=",
         "ref": "refs/heads/main",
-        "rev": "a7762d6f54b40560dd5255ce902e6e6a5d980fe9",
+        "rev": "77d2389874bb092b8dbf05ecc5b1030372e80e98",
-        "revCount": 1416,
+        "revCount": 1417,
         "type": "git",
         "url": "https://spectrum-os.org/git/spectrum"
       },

flake.nix

@@ -7,8 +7,6 @@
     mtce.inputs.nixpkgs.follows = "nixpkgs";
     microvm.url = "github:microvm-nix/microvm.nix";
     microvm.inputs.nixpkgs.follows = "nixpkgs";
-    deploy-label.url = "path:./misc/deploy-label";
-    deploy-label.flake = false;
   };
 
   outputs =
@@ -17,7 +15,6 @@
       nixpkgs,
       mtce,
       microvm,
-      deploy-label,
       ...
     }:
     let
@@ -26,12 +23,6 @@
       pkgs = import nixpkgs { inherit system; };
 
       flakeRev = self.shortRev or self.dirtyShortRev or "unknown";
-      deployLabel =
-        let
-          labelFile = "${deploy-label}/label";
-          raw = lib.removeSuffix "\n" (builtins.readFile labelFile);
-        in
-        if raw != "" then raw else null;
 
       customPkgs = {
         hopper-rs = pkgs.callPackage ./packages/hopper-rs.nix { };
@@ -65,7 +56,7 @@
 
       specialArgsFor = hostName: {
         hostInfo = hostInfoFor hostName;
-        inherit inputs customPkgs flakeRev deployLabel;
+        inherit inputs customPkgs flakeRev;
       };
 
       hostDefFor =

scripts/server-autodeploy.sh

@@ -48,17 +48,13 @@ runas git tag -v "$latest" || {
 sha=$(runas git rev-list -1 "$latest")
 report_status "pending" "deploying $latest" "$sha"
 
-label_dir=$(mktemp -d)
-echo "$latest" > "$label_dir/label"
 flake_url="git+${GITEA_URL}/${GITEA_REPO}?ref=refs/tags/${latest}&rev=${sha}#$HOSTNAME"
 
-if nixos-rebuild switch --flake "$flake_url" --override-input deploy-label "path:$label_dir"; then
+if nixos-rebuild switch --flake "$flake_url"; then
-  rm -rf "$label_dir"
   echo "$latest" > "$STATE_DIR/tag"
   report_status "success" "deployed $latest" "$sha"
   echo "deployed $latest"
 else
-  rm -rf "$label_dir"
   report_status "failure" "nixos-rebuild failed" "$sha"
   exit 1
 fi